Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nlp): support weekly by hour texts #590

Merged
merged 3 commits into from
Nov 10, 2023
Merged

feat(nlp): support weekly by hour texts #590

merged 3 commits into from
Nov 10, 2023

Conversation

paviad
Copy link
Contributor

@paviad paviad commented Jul 7, 2023 •
edited
Loading

e.g. 'every week on Sunday at 10, 12 and 17' would serialize to
'RRULE:FREQ=WEEKLY;BYDAY=SU;BYHOUR=10,12,17'

Closes #589

Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

@paviad
feat(nlp): support weekly by hour texts
115ce40 
 e.g. 'every week on Sunday at 10, 12 and 17' would serialize to
 'RRULE:FREQ=WEEKLY;BYDAY=SU;BYHOUR=10,12,17'
@paviad
after prettier
ea24781
@paviad
forgot to add a case
62e3457
@davidgoli davidgoli merged commit 62e7320 into jkbrzt:master Nov 10, 2023
@davidgoli
Copy link
Collaborator

Thanks for the contribution!

@paviad paviad deleted the weekly-by-hour branch November 10, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NLP: Support weekly by hour patterns
2 participants
@paviad @davidgoli