tests: Make logging the resources deterministic #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The termination of promises is non deterministic, in particular it means we can't rely on std.log for resource1 to be called before std.log for resource2. Instead, let's wait for all promises to be resolved and than cycle though their values to log them to stdout.
dlespiau
force-pushed
the
2019-03-05-resource-deterministic-loading
branch
from
717f141
to
d5f8570
Compare
|
Awps! Good catch (see also #110) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The termination of promises is non deterministic, in particular it means we
can't rely on std.log for resource1 to be called before std.log for resource2.
Instead, let's wait for all promises to be resolved and than cycle though their
values to log them to stdout.