Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many new features #134

Merged
merged 52 commits into from
Sep 14, 2021
Merged

Many new features #134

merged 52 commits into from
Sep 14, 2021

Conversation

diondokter
Copy link
Contributor

@diondokter diondokter commented Sep 10, 2021

Closes #133

  • Double buffering RX
  • RSSI and LOS calculations
  • Sleep and wakeup
  • Range bias calculations
  • External sync modes (for TDOA systems)
  • HL split up into multiple files (one for each state) because it got way too big
  • Probably more small things that I don't really remember

Note: Throughout the commits you may see some stuff about SPI delays and stuff. All of that was taken out in the end.
My SPI just wasn't set up properly, so I had some problems I could mask with setting some delays.

Added function to pull the CS pin low for 500us.
Added new sleeping state.
Added function to put a ready radio to sleep.
Added function to wake up a sleeping radio.
# Conflicts:
#	dw1000/Cargo.toml
#	dwm1001/Cargo.toml
#	dwm1001/src/lib.rs
Added better cs delay
@hannobraun
Copy link
Contributor

Thank you, @diondokter! I'll try to take a look next week, but it might be a bit later (coming back from vacation next week, and there's a backlog to catch up on).

@diondokter
Copy link
Contributor Author

Don't worry! This stuff is more than half a year old, so one or more weeks won't make a difference :)

Copy link
Contributor

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again, @diondokter, these are awesome additions! I took a look and everything looks reasonable, although to be honest, I didn't look to closely at a lot of it. It's just too much to properly review, given the time I have available.

The only problem I found is that (at least some of) the examples aren't building (looks like CI didn't run for this PR, see #128). I'm looking into that right now.

@diondokter
Copy link
Contributor Author

diondokter commented Sep 14, 2021

Ah right! Didn't test that. I'll try to find a bit of time to fix the examples.
Edit: Oh never mind, you did it already :P

@hannobraun
Copy link
Contributor

Turns out the example were pretty trivial to fix. I pushed a commit that does it. I didn't test that they actually work, for lack of time. I'll do that later (need to do it anyway for #135).

I'm going to merge this now. Having such a large pull request sit open for too long won't help anyone. Thanks again, @diondokter!

@hannobraun hannobraun merged commit 887fd56 into jkelleyrtp:master Sep 14, 2021
@diondokter
Copy link
Contributor Author

Thank you as well! Learned a lot by working on this repo.
I even made a crate that helps with register definitions based on the ideas this repo has.
https://crates.io/crates/device-driver
It needs more love though...

This is a good driver that helped me quickly develop my system. Thanks!

@jkelleyrtp jkelleyrtp mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is a mega PR welcome?
2 participants