Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failed sdr devices better #19

Closed
jketterl opened this issue Oct 7, 2019 · 6 comments
Closed

Handle failed sdr devices better #19

jketterl opened this issue Oct 7, 2019 · 6 comments

Comments

@jketterl
Copy link
Owner

jketterl commented Oct 7, 2019

when an sdr device fails, connected users potentially enter a reconnect loop; the user interface is pretty much unusable, and other sdr devices that may still be functioning are inaccessible.

ideally, openwebrx would remove failed devices from the profiles dialog. if no devices are left, a message should appear that no sdr devices are availalbe.

also, users that are using an sdr at the moment it fails should receive a message about what happened, informing them to switch to another profile.

@jketterl
Copy link
Owner Author

jketterl commented Oct 7, 2019

one case of this happening has been brought forward in #18

@d9394
Copy link

d9394 commented Oct 8, 2019

That's a good idea

@jketterl
Copy link
Owner Author

The latest version in develop has some patches to show a message in the websites' log panel if something goes wrong. it should also prevent the client/server reconnect loop. Of course, when I went to test it, all my sdrs worked like a charm... I'll have to run this for some time to see if there's anything I messed up or missed.

@d9394
Copy link

d9394 commented Oct 13, 2019

Roger, I will build a new docker image for test new commit.

@d9394
Copy link

d9394 commented Oct 14, 2019

I had builded a new docker image ,and test it about an hour, that' great improve , very stable runing on my nas.

@jketterl
Copy link
Owner Author

Here's my quick sum-up of what I gathered on this specific issue in the past few weeks:

  • The error message is too easy to overlook, it even happens to me. I'd like to use the existing "press to start" overlay do display a modal message.
  • It doesn't catch all error cases, sometimes its starts a reconnection loop together with the client, until the available connections are exhausted. The client still keeps looping then (separate issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants