Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test upgrade and bugfix for unformatted files #70

Merged
merged 28 commits into from
Jul 2, 2019
Merged

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Jun 21, 2019

Description

Addresses #62.

  • Additional unit tests
    • Now checks for runs and loads with both the formatted and unformatted output options
    • Basic check for Model.repr()
    • Added tests for input of fourier series for ExB drifts
    • Separated test archive data for unformatted and formatted data to different days.
    • Updated test code to use os.path.join to improve platform independence.
    • Removed test codes from coverage report
  • Bugfix for unformatted data load
  • Bugfix for check for standard data as part of repr
  • Update to pull request template
  • PEP8 scrub

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jklenzing jklenzing added bug Something isn't working testing unit tests for code labels Jun 21, 2019
@jklenzing jklenzing added this to the 0.1.2 Release milestone Jun 21, 2019
@jklenzing jklenzing merged commit 046bd9c into develop Jul 2, 2019
@jklenzing jklenzing deleted the unit_tests branch July 2, 2019 18:22
@jklenzing jklenzing mentioned this pull request Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing unit tests for code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants