Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use setup.cfg for metadata, build sami2py.x without Make #72

Merged
merged 1 commit into from
Jul 4, 2019
Merged

use setup.cfg for metadata, build sami2py.x without Make #72

merged 1 commit into from
Jul 4, 2019

Conversation

scivision
Copy link
Contributor

  • modernize setup: no need to have metadata in setup.py, in general we seek to minimize length of setup.py for code auditing and easier metadata parsing by moving as much as possible to setup.cfg
  • specify numpy requirement
  • include basic flake8/mypy template
  • build sami2py.x without needing Make, relevant for Windows users in particular. Also easy to switch between compilers by just adding additional line per compiler (if ifort, etc)

In general, sami2py is now seamlessly easier to install and meets better metadata quality standard for Python with no user-apparent changes.

@scivision
use setup.cfg for metadata, build sami2py.x without Make
ae09c20 
future print_function

py27 no shutil.which()
@jklenzing jklenzing self-requested a review July 3, 2019 15:18
@scivision
Copy link
Contributor Author

I can say, before this PR we could not install sami2py on Windows, and now it's effortless.

@scivision scivision mentioned this pull request Jul 3, 2019
Merged
@jklenzing
Copy link
Member

Happy to hear this works on windows now. Will check this out on my system tonight.

@jklenzing jklenzing added this to the 0.2.0 Release milestone Jul 3, 2019
jklenzing
jklenzing approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Merging. Thanks!

@jklenzing jklenzing merged commit 9984bf7 into sami2py:develop Jul 4, 2019
@jklenzing jklenzing mentioned this pull request Jul 4, 2019
Merged
9 tasks
@scivision scivision deleted the develop branch July 5, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklenzing jklenzing jklenzing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@scivision @jklenzing