Use TypeScript

[jkomoros]

No description provided.

[jkomoros]

https://www.typescriptlang.org/docs/handbook/migrating-from-javascript.html
https://github.com/lit/lit-element-starter-ts

[jkomoros]

• Switch to using '@rollup/plugin-typescript' in rollup once card-web-app is a typescript
• Configure eslint/typescript: https://khalilstemmler.com/blogs/typescript/eslint-for-typescript/
• Remove 'allowJs' (if that's useful)
• Make sure ts-lit-plugin works (does it need an npm install>)
• https://redux.js.org/usage/usage-with-typescript
• Use ReturnType or something similar to set valid enum values for things like ConfigActioN?
• Make npm run build not use ';' but '&&' once tsc build doesn't error
• Enable 'noImplicitAny'
• Use the patterns for dispatch and thunk from PWA Starter Kit Typescript branch: https://github.com/Polymer/pwa-starter-kit/blob/template-typescript/src/actions/app.ts
• Enable 'strict'
• Add types for actions (using the kind type switch) (or maybe don't? https://phryneas.de/redux-typescript-no-discriminating-union)
• Enable 'noImplicitThis'
• Try using AppActionCreator on every thunk action creator 🤷
• Figure out how to use AppActionCreator for async action creators
• Enable 'strictNullChecks'
• Enable 'noEmitOnError'
• Make card.full_bleed be a non-optional property (needs a maintenance task?)
• Fix test failure in npm run test:references introduced in ccf53b1 (actually it looks like 8509364 ?)
• Consider moving tsc build into an intermediate build_ts instead of hidiing all of the generated stuff in src
• Make permission type name an explicit type, not just string
• Reordering cards to drag below now jumps two slots down
• Turn on no-missing-element-type-definition https://marketplace.visualstudio.com/items?itemName=runem.lit-plugin#no-missing-element-type-definition)
• Verify screenshot service works, after e9b777c
• Figure out a way to get rid of card_diff: NON_AUTOMATIC_MERGE_FIELDS and just use NonAutoMergeableCardDiff type somehow
• Should CustomEvent.detail have types based on kind?
• conceptCardsFromCards should be able to take Cards or Processed cards and return that type and not require casts from downstream users
• Use typescript for functions/
• Fix break in 997123f
• Use typescritp for test
• Deploys are broken because eslint for the functions package breaks. See Use TypeScript #601 (comment) for more. Tracked in Fix firebase functions deploy #607
• Fix bug where while loading card says "content goes here" bisect blames: 1fd128c
• Fix broken basic-card renderer broke in 296fb21
• Figure out if htere's a way to have CardUpdate have ONLY those fields, not extras? https://fettblog.eu/typescript-match-the-exact-object-shape/
• Use Redux toolkit for action creators, to handle getting types on actions properly? https://redux-toolkit.js.org/usage/usage-guide see also https://phryneas.de/redux-typescript-no-discriminating-union
• Any action creator that is typed AppActionCreator has a signature of any[], which could obscure callsite problems.
• Consider memoizing objectWithReferences
• For all if(! ele instance of HTML*Element)) checks in components.ts, instead of doing narrowing via silent return, throw an error.
• Use built-in utility types, like Partial, Record, etc: https://www.typescriptlang.org/docs/handbook/utility-types.html
• Instead of enumerating globalEvents for https://marketplace.visualstudio.com/items?itemName=runem.lit-plugin#-no-unknown-event, enumerate them in jsdoc above each component that fires them
• tweetOrderExtractor should do its own typing
• Do all todos in events.ts
• rename card_field_constants.ts to type_constants.ts
• Do all TODOs in types.ts
• Squelch warnings in npm run build about _decorator and undefined this. Veri
• Consider using something like https://stackoverflow.com/a/62055863 for Object.keys(), Object.entries(), and Object.values() type safety (we currently do a lot of 'as' assertions, but it seems like those could break if the shape of various objects changed?)
• Go in and explicitly add implied types to all call signatures (especially in top-level ts files)

[jkomoros]

Move all js to ts (including config.secret.json generation), have a git_ignore of src/**.js,

Re copy config.SECRET.json .

Don't have tsc inline files in src (that's super-confusing/messy), just have it in build_ts/

Make sure npm run build works (even if you haven't done npm run serve)

Get eslint errors suprressed in generated files in src/