Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from blaze-builder to bytestring's Builder. #15

Conversation

leonbaum
Copy link

io-streams-3.0.0 switched from blaze-builder to bytestring's new Builder, so to make kdb-haskell build with it, this patch was required.

@jkozlowski
Copy link
Owner

Hey, i am travelling this week, I will look at this as soon as I come back.

Jakub

Sent from my iPhone

On 30 Apr 2015, at 12:38, leonbaum notifications@github.com wrote:

io-streams-3.0.0 switched from blaze-builder to bytestring's new Builder, so to make kdb-haskell build with it, this patch was required.

You can view, comment on, or merge this pull request online at:

#15

Commit Summary

Migrate from blaze-builder to bytestring's Builder.
File Changes

M benchmarks/Benchmark.hs (4)
M kdb-haskell.cabal (6)
M src/Database/Kdb/Internal/Client.hs (10)
M src/Database/Kdb/Internal/IPC.hs (73)
M src/Database/Kdb/Internal/Types/ClientTypes.hs (2)
M tests/Database/Kdb/Internal/IPCTest.hs (4)
Patch Links:

https://github.com/jkozlowski/kdb-haskell/pull/15.patch
https://github.com/jkozlowski/kdb-haskell/pull/15.diff

Reply to this email directly or view it on GitHub.

@@ -39,7 +39,7 @@ library
default-language: Haskell2010
build-depends: base >= 4 && < 5, transformers
, deepseq
, network, io-streams, exceptions, blaze-builder, attoparsec
, network, io-streams, exceptions, attoparsec
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking the io-streams dependency might need a bound now? >= 1.3.0.0

@jkozlowski
Copy link
Owner

I should also probably fix the stupid travis build before I merge this. I am having a bit of difficulty with my Haskell setup recently, hence why this project has not seen much love recently...

@jkozlowski jkozlowski closed this May 14, 2015
@jkozlowski
Copy link
Owner

Oops, apologies for closing this. I didn't even realise I did.

@jkozlowski
Copy link
Owner

Closing in favour of #17

@jkozlowski jkozlowski closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants