Improve code coverage

Author: jkphl

src/Respimgcss/Infrastructure/SourceSizeList.php

@@ -37,6 +37,7 @@
 namespace Jkphl\Respimgcss\Infrastructure;
 
 use Jkphl\Respimgcss\Application\Model\SourceSize;
+use Jkphl\Respimgcss\Ports\InvalidArgumentException;
 
 /**
  * Sizes list
@@ -46,20 +47,25 @@
  */
 class SourceSizeList extends \ArrayObject
 {
-    /**
-     * Source sizes
-     *
-     * @var SourceSize[]
-     */
-    protected $sourceSizes;
-
     /**
      * Source size list constructor
      *
      * @param SourceSize[] $sourceSizes Source sizes
+     *
+     * @throws InvalidArgumentException If the source size is invalid
      */
     public function __construct(array $sourceSizes)
     {
-        $this->sourceSizes = $sourceSizes;
+        // Run through all source sizes
+        foreach ($sourceSizes as $sourceSize) {
+            // If the source size is invalid
+            if (!($sourceSize instanceof SourceSize)) {
+                throw new InvalidArgumentException(
+                    InvalidArgumentException::INVALID_SOURCE_SIZE_STR,
+                    InvalidArgumentException::INVALID_SOURCE_SIZE
+                );
+            }
+        }
+        parent::__construct($sourceSizes);
     }
 }

src/Respimgcss/Ports/InvalidArgumentException.php

@@ -68,4 +68,16 @@ class InvalidArgumentException extends \Jkphl\Respimgcss\Application\Exceptions\
      * @var int
      */
     const INVALID_WORD_TOKEN_IN_SOURCE_SIZE_VALUE = 1522701212;
+    /**
+     * Invalid source size
+     *
+     * @var string
+     */
+    const INVALID_SOURCE_SIZE_STR = 'Invalid source size';
+    /**
+     * Invalid source size
+     *
+     * @var int
+     */
+    const INVALID_SOURCE_SIZE = 1523047851;
 }

src/Respimgcss/Tests/Infrastructure/SourceSizeListTest.php

@@ -0,0 +1,75 @@
+<?php
+
+/**
+ * responsive-images-css
+ *
+ * @category   Jkphl
+ * @package    Jkphl\Respimgcss
+ * @subpackage Jkphl\Respimgcss\Tests\Infrastructure
+ * @author     Joschi Kuphal <joschi@kuphal.net> / @jkphl
+ * @copyright  Copyright © 2018 Joschi Kuphal <joschi@kuphal.net> / @jkphl
+ * @license    http://opensource.org/licenses/MIT The MIT License (MIT)
+ */
+
+/***********************************************************************************
+ *  The MIT License (MIT)
+ *
+ *  Copyright © 2018 Joschi Kuphal <joschi@kuphal.net> / @jkphl
+ *
+ *  Permission is hereby granted, free of charge, to any person obtaining a copy of
+ *  this software and associated documentation files (the "Software"), to deal in
+ *  the Software without restriction, including without limitation the rights to
+ *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+ *  the Software, and to permit persons to whom the Software is furnished to do so,
+ *  subject to the following conditions:
+ *
+ *  The above copyright notice and this permission notice shall be included in all
+ *  copies or substantial portions of the Software.
+ *
+ *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+ *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+ *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ ***********************************************************************************/
+
+namespace Jkphl\Respimgcss\Tests\Infrastructure;
+
+use Jkphl\Respimgcss\Application\Factory\SourceSizeFactory;
+use Jkphl\Respimgcss\Infrastructure\SourceSizeList;
+use Jkphl\Respimgcss\Infrastructure\ViewportCalculatorServiceFactory;
+use Jkphl\Respimgcss\Tests\AbstractTestBase;
+
+/**
+ * Source size list test
+ *
+ * @package    Jkphl\Respimgcss
+ * @subpackage Jkphl\Respimgcss\Tests\Infrastructure
+ */
+class SourceSizeListTest extends AbstractTestBase
+{
+    /**
+     * Test the source size list
+     */
+    public function testSourceSizeList()
+    {
+        $sourceSizeFactory = new SourceSizeFactory(new ViewportCalculatorServiceFactory(), 16);
+        $sourceSize        = $sourceSizeFactory->createFromSourceSizeStr('(min-width: 100px) 100vw');
+        $sourceSizeList    = new SourceSizeList([$sourceSize]);
+        $this->assertInstanceOf(SourceSizeList::class, $sourceSizeList);
+        $this->assertEquals(1, count($sourceSizeList));
+        $this->assertEquals($sourceSize, $sourceSizeList[0]);
+    }
+
+    /**
+     * Test the source size list with invalid source size
+     *
+     * @expectedException \Jkphl\Respimgcss\Ports\InvalidArgumentException
+     * @expectedExceptionCode 1523047851
+     */
+    public function testSourceSizeListInvalid()
+    {
+        new SourceSizeList(['test']);
+    }
+}