Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Added english translations improvements from korhaldragonir #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Jun 4, 2016

Creating the pull request for reviews. See #75

@Jbaukens
Copy link
Contributor

Jbaukens commented Jun 6, 2016

I would honestly not use it, some are good but some have really nothing to do with ogame terms :/

@jkroepke
Copy link
Owner Author

jkroepke commented Jun 6, 2016

A lot translation are better as before. We should improve it. If you miss some OGame terms, we should add them.

@BassXX
Copy link

BassXX commented Jun 15, 2016

Why you actually renamed Hall of Fame to "Famous Battles" ? I think Hall of Fame sounds better.

A lot is better than before, but there are still some sentences which sounds quite weird to me.

I will read the entire translation the next days...Maybe we could suggest some improvements by listing all the terms, which sounds "strange" ?

@jkroepke
Copy link
Owner Author

You can create comments on every line. That should be the best.

BassXX <notifications@github.commailto:notifications@github.com> schrieb am Mi., 15. Juni 2016, 11:13:

Why you actually renamed Hall of Fame to "Famous Battles" ? I think Hall of Fame sounds better.

A lot is better than before, but there are still some sentences which sounds quite weird to me.

I will read the entire translation the next days...Maybe we could suggest some improvements by listing all the terms, which sounds "strange" ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/207#issuecomment-226131893, or mute the threadhttps://github.com/notifications/unsubscribe/ABfQC13rd0Y692nAZAEW9jHa1oozYX2Mks5qL8H4gaJpZM4IuNMS.

$LNG['ub_quote'] = 'Ratio';
$LNG['ub_rank'] = 'Global Rank';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Rank should be enough

@jkroepke
Copy link
Owner Author

I try to setup a translations service on transifex.com for better translations.

@BassXX
Copy link

BassXX commented Jun 17, 2016

Okay, I will have a look onto it later

@jkroepke
Copy link
Owner Author

It depends on #225, I have to change some code to use the service.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants