Detect Meteor Node version for Dockerfile. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkrup Meteor 1.9 has just been recommended, which uses Node 12.14.0. I think this change would help those that would like to upgrade to the new version. |
|
It works like a charm. Please merge this @jkrup |
|
I can confirm that this fixes the issue. It would be very helpful to merge this @jkrup - thanks! |
|
and @moberegger thanks for sharing the patch :-) |
|
Thanks for the PR! |
|
Wooooo, I did something useful! 😆 |
|
@jkrup Do you have any plan to release a new version ... I just stepped into the same issue again ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile has the Node version hardcoded to
8.15.1. The latest recommended version of Meteor is 8.17.0. Meteor 1.9 has also just been released, which uses Node 12.14.0.I figured instead of having to constantly update the Dockerfile with each release just let the deployment script figure out what Node version the installed Meteor uses, and then use that in the Dockerfile.