Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buffer field in PerstArtifact #7

Closed
arcanefoam opened this issue May 15, 2017 · 1 comment
Closed

Remove buffer field in PerstArtifact #7

arcanefoam opened this issue May 15, 2017 · 1 comment

Comments

@arcanefoam
Copy link
Contributor

The buffer field is private with no access methods, thus it is only used internally. However, AFAICT it is only accessed in the setData and getData methods. In the setData, it is used under the assumption that the ArtifactData is serializabe. There might be cases in which the data being loaded into ECCO is not, e.g. EMF EObjects are not (by default).
In the getData, it is used to recreate the data from the buffer in case the data is null., but since the buffer can not be filled/set elsewhere there is no way this is actually helpfull.

@arcanefoam
Copy link
Contributor Author

The buffer is part of a serialization mechanism. So no change needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant