Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround pure-ftpd connections failing with "Unknown command" #190

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

ncw
Copy link
Contributor

@ncw ncw commented Jul 18, 2020

pure-ftpd 1.0.49-4 as supplied as part of Ubuntu 20.04 advertises UTF8
support in the FEAT command but the OPTS command fails to turn it on.

OPTS UTF8 ON
504 Unknown command

This patch introduces a workaround to ignore the error which enables
this library to work with this version of pure-ftpd. Filezilla appears
to ignore this error in a similar way.

pure-ftpd 1.0.49-4 as supplied as part of Ubuntu 20.04 advertises UTF8
support in the FEAT command but the OPTS command fails to turn it on.

    OPTS UTF8 ON
    504 Unknown command

This patch introduces a workaround to ignore the error which enables
this library to work with this version of pure-ftpd. Filezilla appears
to ignore this error in a similar way.
@jlaffaye jlaffaye merged commit 13949d3 into jlaffaye:master Jul 20, 2020
@ncw
Copy link
Contributor Author

ncw commented Jul 21, 2020

Thanks for merging :-)

This is a great project and there are lots of happy rclone users using this library!

ncw added a commit to rclone/rclone that referenced this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants