Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DialWithDisabledMLSD option to ignore MLSD if advertised #196

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ncw
Copy link
Contributor

@ncw ncw commented Sep 4, 2020

This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will auto close after 14 days label Oct 4, 2020
@ncw
Copy link
Contributor Author

ncw commented Oct 5, 2020

Just tickling the stale bot - I'd like this merged if poss as it fixes an rclone users problems!

@stale stale bot removed the stale Will auto close after 14 days label Oct 5, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Will auto close after 14 days label Nov 5, 2020
This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.
@stale stale bot removed the stale Will auto close after 14 days label Nov 5, 2020
@ncw
Copy link
Contributor Author

ncw commented Nov 5, 2020

I rebased this patch - can you take another look please - thanks :-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 74.293% when pulling 624bcac on ncw:fix-disable-mlsd into 0de5c29 on jlaffaye:master.

ncw added a commit to rclone/rclone that referenced this pull request Nov 5, 2020
This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.

See: https://forum.rclone.org/t/double-folder-names-on-target-destination-paths-ftp/18822
See: jlaffaye/ftp#196
@jlaffaye jlaffaye merged commit 9aae4d1 into jlaffaye:master Nov 12, 2020
@ncw ncw deleted the fix-disable-mlsd branch November 13, 2020 11:22
ncw added a commit to rclone/rclone that referenced this pull request Nov 13, 2020
This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.

See: https://forum.rclone.org/t/double-folder-names-on-target-destination-paths-ftp/18822
See: jlaffaye/ftp#196
@ncw
Copy link
Contributor Author

ncw commented Nov 13, 2020

Thank you for merging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants