GitHub: Cross build full matrix #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
jlduran
force-pushed
the
github-cross-build-full-matrix
branch
6 times, most recently
from
2c2a8f7
to
086c275
Compare
|
Or maybe just oldest & newest (12 & 15)?
|
jlduran
force-pushed
the
github-cross-build-full-matrix
branch
from
086c275
to
7aa78e4
Compare
jlduran
pushed a commit
that referenced
this pull request
Sep 11, 2023
netlink(4) calls back into the driver during detach and it attempts to start an internal synchronized op recursively, causing an interruptible hang. Fix it by failing the ioctl if the VI has been marked as DOOMED by cxgbe_detach. Here's the stack for the hang for reference. #6 begin_synchronized_op #7 cxgbe_media_status #8 ifmedia_ioctl #9 cxgbe_ioctl #10 if_ioctl #11 get_operstate_ether #12 get_operstate #13 dump_iface #14 rtnl_handle_ifevent #15 rtnl_handle_ifnet_event #16 rt_ifmsg #17 if_unroute #18 if_down #19 if_detach_internal #20 if_detach #21 ether_ifdetach #22 cxgbe_vi_detach #23 cxgbe_detach #24 DEVICE_DETACH MFC after: 3 days Sponsored by: Chelsio Communications
Add this branch to the list just to test it.
Implement a full cross-build matrix using all supported Clang versions using the latest versions of GitHub-hosted runners. The following additional changes were made: - Split the "Create environment" step, one for each OS. Though, more verbose, it facilitates customization and readability. - The mechanism to detect the number of processors was dropped to set a fixed number based on current GitHub runner's documentation [1]. - Consistent naming convention/capitalization. [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
Test displaying a matrix (e.g., useful when one of the builds fail for a particular tuple of OS, architecture, and LLVM version).
It is bound to happen at some point.
jlduran
force-pushed
the
github-cross-build-full-matrix
branch
from
7aa78e4
to
0013cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interesting exercise of testing a full matrix of supported clang versions on different OSs.
Random timeouts, specifically on macOS were noticed, there are just too many options.
Suggestion: Remove amd64 on macOS, as this will soon disappear.