NanoBSD cleanup #64
Open
NanoBSD cleanup #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlduran
commented
Jan 4, 2024
tools/tools/nanobsd/defaults.sh
Outdated
| CONF_WORLD=' | ||
| WITHOUT_LIB32=true | ||
| WITHOUT_TESTS=true | ||
| WITHOUT_DEBUG_FILES=t |
| MODULES_OVERRIDE=netgraph rc4 | ||
| BOOT_PXELDR_PROBE_KEYBOARD=1 | ||
| BOOT_PXELDR_ALWAYS_SERIAL=1 | ||
| BOOT_COMCONSOLE_SPEED=9600 | ||
| $CONF_WORLD | ||
| ' |
There was a problem hiding this comment.
Double quote instead of single.
| cust_comconsole() | ||
| ( | ||
| # Disable getty on syscons devices | ||
| sed -i "" -e '/^ttyv[3-8]/s/\tonifexists/\toff\ \ \ \ \ \ \ /' ${NANO_WORLDDIR}/etc/ttys |
| ln -s ld-elf.so.1 ld-elf32.so.1 | ||
| fi | ||
| # Disable getty on serial consoles | ||
| sed -i "" -e '/^ttyu[1-3]/s/\tonifconsole/\toff\ \ \ \ \ \ \ \ /' ${NANO_WORLDDIR}/etc/ttys |
| #ifconfig_fxp0="AUTO" | ||
| #sshd_enable="YES" | ||
| EOF | ||
| cat > etc/fstab <<- EOF |
| # makefs converts labels to uppercase anyways | ||
| BIGLABEL=$(toUpper "${NANO_LABEL}") | ||
| cat > etc/fstab <<- EOF | ||
| /dev/iso9660/${BIGLABEL} / cd9660 ro,noatime 0 0 |
|
jlduran
force-pushed
the
nanobsd-cleanup
branch
from
227bbd4
to
ee6ee79
Compare
Remove unused subroutines, clean up the code.
TODO: shellcheck
TODO: Revert the fstab spacing (excessive, no need to match mount -p)
NOTE that this commit will probably be discarded. TODO: Remove extra spaces
This brings back the output sizes of NanoBSD images, make it a global default per @imp's recommendation. Adjust other scripts that used to override the CONF_WORLD environment variable, so that the default value is appended.
The README promises a DHCP server based on the dnsmasq package. Actually install the dnsmasq package.
Add the base files that facilitate NanoBSD's maintenance.
Otherwise the instructions in the article [^1] will fail due to a lack of space. [^1]: https://docs.freebsd.org/en/articles/nanobsd/
Missing: - Overlay Files from base - Cleanup common.conf - Cleanup test.sh Test?
jlduran
force-pushed
the
nanobsd-cleanup
branch
from
2d3ab5e
to
c730682
Compare
jlduran
force-pushed
the
nanobsd-cleanup
branch
from
c730682
to
597f37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief NanoBSD cleanup, allows for building according to the respective README files and the NanoBSD article.