fix(install): invoke npm install hook

Author: jlegrone

packages/create-semantic-module/src/index.js

@@ -1,15 +1,15 @@
-import {createEnv} from 'yeoman-environment';
+const yoEnv = require('yeoman-environment');
 
-function createSemanticModule(args) {
-  const env = createEnv();
+function createSemanticModule(args = []) {
+  const env = yoEnv.createEnv();
 
   env.register(
     require.resolve('generator-semantic-module'),
     'semantic-module:app'
   );
 
   env.run('semantic-module:app', {
-    'module-name': (args || [])[0]
+    'module-name': (args)[0]
   });
 }
 

packages/generator-semantic-module/src/__tests__/__snapshots__/app.js.snap

@@ -0,0 +1,131 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`create new module creates files: commitlint.config.js 1`] = `
+"/* eslint-env node */
+
+module.exports = {// Add your own rules. See http://marionebl.github.io/commitlint
+  rules: {
+  }
+};
+"
+`;
+
+exports[`create new module creates files: package.json 1`] = `
+"{
+  \\"config\\": {
+    \\"commitizen\\": {
+      \\"path\\": \\"node_modules/@commitlint/prompt\\"
+    }
+  },
+  \\"scripts\\": {
+    \\"commit\\": \\"git-cz\\",
+    \\"commit:retry\\": \\"git-cz --retry\\",
+    \\"commitmsg\\": \\"commitlint -e\\"
+  }
+}
+"
+`;
+
+exports[`use command line arguments creates files: commitizen.config.js 1`] = `
+"/* eslint-env node */
+
+const types = [
+  {
+    value: 'feat',
+    name: 'feat:     A new feature'
+  },
+  {
+    value: 'fix',
+    name: 'fix:      A bug fix'
+  },
+  {
+    value: 'docs',
+    name: 'docs:     Documentation only changes'
+  },
+  {
+    value: 'style',
+    name: \`style:    Changes that do not affect the meaning of the code
+            (white-space, formatting, missing semi-colons, etc)\`
+  },
+  {
+    value: 'refactor',
+    name: 'refactor: A code change that neither fixes a bug nor adds a feature'
+  },
+  {
+    value: 'perf',
+    name: 'perf:     A code change that improves performance'
+  },
+  {
+    value: 'test',
+    name: 'test:     Adding missing tests'
+  },
+  {
+    value: 'chore',
+    name: \`chore:    Changes to the build process or auxiliary tools
+            and libraries such as documentation generation\`
+  },
+  {
+    value: 'revert',
+    name: 'revert:   Revert to a commit'
+  }
+];
+
+const scopes = [
+  'example-1',
+  'example-2'
+].map(name => ({ name }));
+
+module.exports = {
+  types,
+  scopes,
+  allowCustomScopes: true,
+  allowBreakingChanges: [
+    'feat',
+    'fix',
+    'perf',
+    'refactor'
+  ]
+};
+"
+`;
+
+exports[`use command line arguments creates files: commitlint.config.js 1`] = `
+"/* eslint-env node */
+
+const { types, scopes, allowCustomScopes } = require('./commitizen.config');
+
+const validTypes = types.map((type) => type.value);
+const validScopes = scopes.map((scope) => scope.name);
+const scopeValidationLevel = allowCustomScopes ? 1 : 2;
+
+module.exports = {
+  extends: ['@commitlint/config-lerna-scopes'],
+
+  // Add your own rules. See http://marionebl.github.io/commitlint
+  rules: {
+    // Apply valid scopes and types
+    'scope-enum': [scopeValidationLevel, 'always', validScopes],
+    'type-enum': [2, 'always', validTypes]
+  }
+};
+"
+`;
+
+exports[`use command line arguments creates files: package.json 1`] = `
+"{
+  \\"config\\": {
+    \\"commitizen\\": {
+      \\"path\\": \\"node_modules/cz-customizable\\"
+    },
+    \\"cz-customizable\\": {
+      \\"config\\": \\"commitizen.config.js\\"
+    }
+  },
+  \\"scripts\\": {
+    \\"commit\\": \\"git-cz\\",
+    \\"commit:retry\\": \\"git-cz --retry\\",
+    \\"commitmsg\\": \\"commitlint -e\\"
+  }
+}
+"
+`;

packages/generator-semantic-module/src/__tests__/app.js

@@ -2,6 +2,10 @@
 const path = require('path');
 const assert = require('yeoman-assert');
 const helpers = require('yeoman-test');
+const {promisify} = require('es6-promisify');
+const fs = require('fs');
+
+const readFile = promisify(fs.readFile);
 
 describe('use command line arguments', () => {
   beforeAll(() => {
@@ -18,16 +22,16 @@ describe('use command line arguments', () => {
       });
   });
 
-  it('creates files', () => {
-    assert.file([
+  it('creates files', async () => {
+    await checkFiles([
       'commitlint.config.js',
       'commitizen.config.js',
       'package.json'
     ]);
   });
 });
 
-describe('create new module', () => {
+describe('create new module', async () => {
   beforeAll(() => {
     return helpers.run(path.join(__dirname, '../generators/app'))
       .withArguments(['my-module'])
@@ -42,10 +46,19 @@ describe('create new module', () => {
     expect(process.cwd().endsWith('/my-module')).toBe(true);
   });
 
-  it('creates files', () => {
-    assert.file([
+  it('creates files', async () => {
+    await checkFiles([
       'commitlint.config.js',
       'package.json'
     ]);
   });
 });
+
+async function checkFiles(files) {
+  assert.file(files);
+
+  return Promise.all(files.map(async file => {
+    const contents = await readFile(file);
+    expect(contents.toString()).toMatchSnapshot(file);
+  }));
+}

packages/generator-semantic-module/src/generators/app/index.js

@@ -1,6 +1,6 @@
-import 'babel-polyfill';
-import Generator from 'yeoman-generator';
-import yosay from 'yosay';
+require('babel-polyfill');
+const Generator = require('yeoman-generator');
+const yosay = require('yosay');
 
 const options = {
   moduleName: 'module-name',
@@ -147,7 +147,7 @@ You can always run create-semantic-module again and select a different option.`)
     this.fs.extendJSON(this.destinationPath('package.json'), packageJSON);
   }
 
-  async install() {
+  install() {
     const packages = [
       'commitizen',
       '@commitlint/cli',
@@ -160,14 +160,24 @@ You can always run create-semantic-module again and select a different option.`)
       packages.push(commitLintConfig);
     }
 
-    const packager = this.config.get(options.packager);
-    const installFlags = packager === 'yarn' ? {
-      dev: true,
-      'ignore-workspace-root-check': true
-    } : {
-      'save-dev': true
-    };
-    await this.runInstall(packager, packages, installFlags);
+    const useYarn = this.config.get(options.packager) === 'yarn';
+
+    if (useYarn) {
+      this.yarnInstall(packages, {
+        dev: true,
+        'ignore-workspace-root-check': true
+      });
+    } else {
+      this.npmInstall(packages, {
+        'save-dev': true
+      });
+    }
+
+    this.installDependencies({
+      yarn: useYarn,
+      npm: !useYarn,
+      bower: false
+    });
   }
 }