Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI configuration file. #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Travis CI configuration file. #12

wants to merge 2 commits into from

Conversation

sbrl
Copy link

@sbrl sbrl commented Dec 16, 2015

This pull request is related to issue #11.
I've added a .travis.yml file that can be used along with Travis CI. The build is currently broken, though.

If you need assistance setting up Travis CI, I'm happy to help.

@jlevy
Copy link
Owner

jlevy commented Jun 1, 2016

Belatedly, thanks for doing this! I'd love to have this working but haven't had much time to enhance it and set up Travis etc.

One issue is, that the run.sh runs the tests but you also need to diff them from the previous output to get a pass/fail reliably (see the script output). And of course we need to fix it so it passes in the first place. So there are a few details to worry about, but you're interested in taking that on and updating this branch once it works, I'd be glad to review/merge.

@sbrl
Copy link
Author

sbrl commented Jun 1, 2016

Gosh, I'd completely forgotten about this!

Yeah, I'm happy to take this on and take a look. What exactly do you mean by

but you also need to diff them from the previous output to get a pass/fail reliably (see the script output)

?

Wouldn't it be enough if the test script exited with a non-zero error code?

Edit: The build does in fact appear to error correctly at the moment in it's current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants