Fix crash when importing big linux perf tool files

Currently, importing files generated by linux perf tool whose some blocks exceed V8 strings limit can crash the application. This issue is similar to the one in #385.

This PR fixes it by changing parseEvents to work directly with lines instead of chunking lines into blocks first.

Fixes #433

src/import/index.ts

@@ -23,7 +23,7 @@ import {decodeBase64} from '../lib/utils'
 import {importFromChromeHeapProfile} from './v8heapalloc'
 import {isTraceEventFormatted, importTraceEvents} from './trace-event'
 import {importFromCallgrind} from './callgrind'
-import {importFromPapyrus} from "./papyrus";
+import {importFromPapyrus} from './papyrus'
 
 export async function importProfileGroupFromText(
   fileName: string,
@@ -189,8 +189,8 @@ async function _importProfileGroup(dataSource: ProfileDataSource): Promise<Profi
       return toGroup(importFromInstrumentsDeepCopy(contents))
     }
 
-    if (/^(Stack_|Script_|Obj_)\S+ log opened \(PC\)\n/.exec(contents.firstChunk())){
-      console.log("Importing as Papyrus profile")
+    if (/^(Stack_|Script_|Obj_)\S+ log opened \(PC\)\n/.exec(contents.firstChunk())) {
+      console.log('Importing as Papyrus profile')
       return toGroup(importFromPapyrus(contents))
     }
 

src/import/linux-tools-perf.ts

@@ -23,8 +23,23 @@ interface PerfEvent {
   stack: PerfStackFrame[]
 }
 
-function parseEvent(rawEvent: string): PerfEvent | null {
-  const lines = rawEvent.split('\n').filter(l => !/^\s*#/.exec(l))
+function parseEvents(contents: TextFileContent): (PerfEvent | null)[] {
+  let events: (PerfEvent | null)[] = []
+  let buffer: string[] = []
+  for (let line of contents.splitLines()) {
+    if (line === '') {
+      events.push(parseEvent(buffer))
+      buffer = []
+    } else buffer.push(line)
+  }
+
+  if (buffer.length > 0) events.push(parseEvent(buffer))
+  return events
+}
+
+// rawEvent is splitted into lines
+function parseEvent(rawEvent: string[]): PerfEvent | null {
+  const lines = rawEvent.filter(l => !/^\s*#/.exec(l))
 
   const event: PerfEvent = {
     command: null,
@@ -81,41 +96,12 @@ function parseEvent(rawEvent: string): PerfEvent | null {
   return event
 }
 
-function splitBlocks(contents: TextFileContent): string[] {
-  // In perf files, blocks are separated by '\n\n'.  If our input was a simple
-  // string, we could use str.split('\n\n'), but since we have a TextFileContent
-  // object which may be backed by several strings, we can't easily split this
-  // way.
-  //
-  // Instead, we'll split into lines, and then re-group runs of non-empty strings.
-  const blocks: string[] = []
-  let pending: string = ''
-  for (let line of contents.splitLines()) {
-    if (line === '') {
-      if (pending.length > 0) {
-        blocks.push(pending)
-      }
-      pending = line
-    } else {
-      if (pending.length > 0) {
-        pending += '\n'
-      }
-      pending += line
-    }
-  }
-  if (pending.length > 0) {
-    blocks.push(pending)
-  }
-  return blocks
-}
-
 export function importFromLinuxPerf(contents: TextFileContent): ProfileGroup | null {
   const profiles = new Map<string, StackListProfileBuilder>()
 
   let eventType: string | null = null
-  const events = splitBlocks(contents).map(parseEvent)
 
-  for (let event of events) {
+  for (let event of parseEvents(contents)) {
     if (event == null) continue
     if (eventType != null && eventType != event.eventType) continue
     if (event.time == null) continue