Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arrayBuffer instead of text for profileURL #179

Merged
merged 2 commits into from
Oct 13, 2018

Conversation

f-hj
Copy link
Contributor

@f-hj f-hj commented Oct 12, 2018

When using #profileURL, some binary characters cannot be read if we use fetch text. So I changed that to use arrayBuffer.

Now we can read pprof protobuf files and normal JSON files instead of only text files.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.459% when pulling 1d36657 on f-hj:f-hj/fix-pprof-profileurl into 0fe0c45 on jlfwong:master.

@jlfwong
Copy link
Owner

jlfwong commented Oct 13, 2018

Whoops! Nice find @f-hj! Thanks for identifying the problem and submitting a working PR fix to it 😄

@jlfwong jlfwong merged commit 86f4ba6 into jlfwong:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants