Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TextDecoder if available for converting from an ArrayBuffer for speed #188

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Use TextDecoder if available for converting from an ArrayBuffer for speed #188

merged 1 commit into from
Nov 8, 2018

Conversation

jlfwong
Copy link
Owner

@jlfwong jlfwong commented Nov 8, 2018

#165 introduced a performance regression by using a really inefficient method for converting from array buffers into string. This should ix it by using TextDecoder instead.

@jlfwong jlfwong merged commit 6562fec into master Nov 8, 2018
@jlfwong jlfwong deleted the jlfwong/decode-opt branch November 8, 2018 18:01
@jlfwong jlfwong mentioned this pull request Nov 8, 2018
Open
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 44.864% when pulling bce7a35 on jlfwong/decode-opt into 23d4042 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlfwong @coveralls