Add profileURL and title hash parameters #19
Conversation
On init, we check the hash fragment for these parameters and load the URL. We always show a loading state in that case rather than the landing screen. When determining the title, an explicitly-specified title takes precedence, otherwise we use the filename. I also added an error state, currently only used for my new code, but possibly there could be a more robust or widespread error handling approach in the future.
| renderError() { | ||
| return ( | ||
| <div className={css(style.error)}> | ||
| <div>😿 Something went wrong.</div> |
hash-params.ts
Outdated
| title?: string | ||
| } | ||
|
|
||
| export default function getHashParams(): HashParams { |
There was a problem hiding this comment.
I haven't really been using default exports for anything anywhere, and IIRC, it makes mocking things kind of a pain. Would you might switching this to just a regular exported function?
There was a problem hiding this comment.
Sure. Not sure about the details of the mocking you're talking about, but at least with the normal commonjs transform, it is possible to mock default exports, I'm pretty sure.
hash-params.ts
Outdated
| const components = hashContents.substr(1).split('&') | ||
| const result: HashParams = {} | ||
| for (const component of components) { | ||
| let [key, value] = component.split('=') |
application.tsx
Outdated
| @@ -343,8 +352,23 @@ export class Application extends ReloadableComponent<{}, ApplicationState> { | |||
| } | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| async componentDidMount() { | |||
There was a problem hiding this comment.
It's a little weird having this function which is part of React's APIs return a promise. Can you extract the code that does the hash loading into an async method and just invoke it from componentDidMount?
There was a problem hiding this comment.
Fair enough. I've done this in my own code without anything going wrong, but agreed it's a little fishy.
On init, we check the hash fragment for these parameters and load the URL. We
always show a loading state in that case rather than the landing screen.
When determining the title, an explicitly-specified title takes precedence,
otherwise we use the filename.
I also added an error state, currently only used for my new code, but possibly
there could be a more robust or widespread error handling approach in the
future.