Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize line & column numbers to be 1-based in Chrome & Firefox imports #318

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Normalize line & column numbers to be 1-based in Chrome & Firefox imports #318

merged 3 commits into from
Oct 2, 2020

Conversation

jlfwong
Copy link
Owner

@jlfwong jlfwong commented Oct 2, 2020

This also fixes a dumb bug in the Firefox import that just completely failed to import column numbers.

@coveralls
Copy link

coveralls commented Oct 2, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 47.233% when pulling 4eacf99 on jlfwong/line-number-imports into 8a4f38a on master.

@jlfwong jlfwong merged commit 16e32dc into master Oct 2, 2020
@jlfwong jlfwong deleted the jlfwong/line-number-imports branch October 2, 2020 21:56
jackerghan pushed a commit to jackerghan/speedscope that referenced this pull request Jul 28, 2023
@jlfwong @jackerghan
Normalize line & column numbers to be 1-based in Chrome & Firefox imp…
de8621e 
…orts (jlfwong#318)

This also fixes a dumb bug in the Firefox import that just completely failed to import column numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlfwong @coveralls