Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Chrome profiles #71

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Clean up Chrome profiles #71

merged 1 commit into from
Jun 25, 2018

Conversation

jlfwong
Copy link
Owner

@jlfwong jlfwong commented Jun 25, 2018

This cleans up imported Chrome profiles in 2 ways:

  1. It places (program) frames on top of the previous call stack, just like we already did for (garbage collector)
  2. It completely removes (root) and (idle) frames, since they aren't semantically useful in the profiles

CC @evanw

@coveralls
Copy link

Pull Request Test Coverage Report for Build 146

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 36.778%
Totals Coverage Status
Change from base Build 141: 0.1%
Covered Lines: 1006
Relevant Lines: 2620
💛 - Coveralls

@jlfwong jlfwong merged commit 27bc4c7 into master Jun 25, 2018
@jlfwong jlfwong deleted the jlfwong/chrome-program-blocks branch June 25, 2018 07:57
@philz philz mentioned this pull request May 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlfwong @coveralls