Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output muons to testbench patterns #10

Closed
jlingema opened this issue Nov 6, 2014 · 11 comments
Closed

Add output muons to testbench patterns #10

jlingema opened this issue Nov 6, 2014 · 11 comments
Assignees

Comments

@jlingema
Copy link
Owner

jlingema commented Nov 6, 2014

No description provided.

@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

@dinyar the output format will be:
OUT N PT PHI ETA SIGN SIGNVALID QUALITY SORTRANK 0 ISO
where N is the rank of the muon. For the intermediate results the same structure as for the inputs will be used.

Btw: Should SIGN+SIGNVALID be one quantity or is this OK?

@dinyar
Copy link
Collaborator

dinyar commented Nov 7, 2014

Yes, that looks good. Will ISO be represented as an int (i.e. 0-3) or as
two bits (i.e. RISO AISO)?

SIGN and SIGNVALID are fine in the current way, I'm still planning on
separating these later on in both the interface and internally.

On Fri Nov 07 2014 at 10:12:26 AM Joschka Lingemann <
notifications@github.com> wrote:

@dinyar https://github.com/dinyar the output format will be:
OUT N PT PHI ETA SIGN SIGNVALID QUALITY SORTRANK 0 ISO
where N is the rank of the muon. For the intermediate results the same
structure as for the inputs will be used.

Btw: Should SIGN+SIGNVALID be one quantity or is this OK?


Reply to this email directly or view it on GitHub
#10 (comment).

@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

Along the same line of reasoning as for the sign/signvalid I would stick to one int for iso (as it is planned to be encoded in one int not two bits)?

@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

Testpatterns were pushed, please check and let me know if they are OK. Then I'll also push the script and close the ticket.

jlingema added a commit that referenced this issue Nov 7, 2014
…uish between inputs / emulator outputs (#10). Also included header to document the format in which muons are written to the file.
@dinyar
Copy link
Collaborator

dinyar commented Nov 7, 2014

Looks good. One thing though: Could you add information which sorter the intermediate came from to the intermediates? (e.g. IMDB, IMDO and IMDF)

@dinyar
Copy link
Collaborator

dinyar commented Nov 7, 2014

Just to clarify: The intermediates are not split into positive and negative at my outputs. The negative side is index 0 to 3 while the positive side is index 4 to 7.

@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

I don't understand fully what you mean with the last comment. Currently the order is:
imd_barrel, imd_ovl_pos, imd_ovl_neg, imd_fwd_neg, imd_fwd_pos... I didn't pay much attention to this as it was only debugging output, the order can of course be changed: What would you like to see?

@dinyar
Copy link
Collaborator

dinyar commented Nov 7, 2014

Ok, the ordering is great. I wasn't sure if negative would be placed before positive.

@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

Well currently it's a mess as for fwd it's the opposite w.r.t. ovl ;).. Will be changed in the next version.

dinyar added a commit to dinyar/uGMTfirmware that referenced this issue Nov 7, 2014
…25. Removed iso bit again as this is not modified in sorter, changed identifier keywords to those used by Joschka in jlingema/uGMTScripts#10. Also reset the expected sort ranks before starting the test.
@dinyar
Copy link
Collaborator

dinyar commented Nov 7, 2014

Ok, awesome. Thanks!

jlingema added a commit that referenced this issue Nov 7, 2014
…tified by region. Numbers are aligned. In accordance with what we discussed in #10.
@jlingema
Copy link
Owner Author

jlingema commented Nov 7, 2014

I guess that closes the issue. If there are any other issues, please let me know.

@jlingema jlingema closed this as completed Nov 7, 2014
dinyar added a commit to dinyar/uGMTfirmware that referenced this issue Nov 7, 2014
…iate muons as per jlingema/uGMTScripts#10 and some other smaller changes. This belongs to #27.
dinyar added a commit that referenced this issue Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants