Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert silent failure when reaching ls_max_fn to stop error. #1

Closed
wants to merge 1 commit into from

Conversation

cdriveraus
Copy link

This caused me a little headache to figure out where the failure 'bracket_step not found' was coming from.

@jlmelville
Copy link
Owner

Thank you for the PR, I'm sorry the error handling and message wasn't very helpful in this case. I will get a new version into CRAN ASAP.

If possible, rather than stopping, I will try and make the behavior so the optimization terminates with a specific message so you can keep whatever progress has been made.

@jlmelville
Copy link
Owner

I believe I have reproduced the error, and have added a test for it. As mentioned above, rather than just a stop, the optimization should now continue as best it can.

@cdriveraus, if you are able to install the current master branch from github (e.g. via the devtools or remotes package), it would be good to know if this fixed the issue for you. Otherwise, I have submitted a new release for mize to CRAN and version 0.2.2 should hopefully show up soon with this fix.

At that point, I will close this PR rather than merge it, due to the conflict resulting from the difference in the code. If the problem isn't solved for you, please re-open (or file an issue).

@cdriveraus
Copy link
Author

Great. I don't have the specific problem up anymore so it would take some fiddling around, I think as long as you've a test that hits ls_max_fn that's all is needed. Thanks for the work on this package, best optimization results I could get after trying a lot of R options :)

@jlmelville
Copy link
Owner

Glad the package is of use. Version 0.2.2 is now on CRAN. I will close when the binaries show up.

@jlmelville
Copy link
Owner

Binaries are on CRAN. Closing.

@jlmelville jlmelville closed this Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants