Add win32 support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Make-based compilation of the nif to using rebar's port compiler.
tolbrino
force-pushed
the
tb-rebar3-win32
branch
from
bba0946
to
26180f4
Compare
|
@jlouis Any feedback on this one? |
|
Looking good, just haven't had the time to push it in :/ |
|
@jlouis Happy new year :-) Got some time now? |
|
@jlouis Friendly ping. |
|
@jlouis Friendly re-ping. I hope this doesn't add me to your spam list. |
|
Lol, it doesn't. It is just that I've had less energy to deal with this project, sadly. Hopefully I can get some time this weekend to deal with this and other pressing parts of the library. |
|
Cool. Let me know if I can help. Neat and useful library!
…On March 7, 2019 6:04:21 PM UTC, Jesper Louis Andersen ***@***.***> wrote:
Lol, it doesn't. It is just that I've had less energy to deal with this
project, sadly. Hopefully I can get some time this weekend to deal with
this and other pressing parts of the library.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#40 (comment)
|
|
@jlouis Let me know if you have time to review. Otherwise I'll close the PR. Thanks. |
|
Way overdue, but looking good. Going in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Make-based compilation of the nif to using rebar's port
compiler.
This is an alternative to #23