-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed some astropy stats issues #15
Conversation
Ha! We were just fixing this. Let me make sure I pushed back up the change.
Maxiters is not supported in the old astropy version.
… On Jun 9, 2020, at 6:12 PM, Tuan Do ***@***.***> wrote:
It looks like calib.py was not importing astropy stats. Also astropy stats does not support the maxiters keyword in the version of astropy (2.0) that works with pyraf and astroconda?
You can view, comment on, or merge this pull request online at:
#15
Commit Summary
fixed some astropy stats issues
File Changes
M nirc2/reduce/calib.py (16)
Patch Links:
https://github.com/jluastro/nirc2/pull/15.patch
https://github.com/jluastro/nirc2/pull/15.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There's also a bug in the instrument code. The CENWAVE keyword does not
exist for OSIRIS.
…On Tue, Jun 9, 2020, 7:40 PM Jessica Lu ***@***.***> wrote:
Ha! We were just fixing this. Let me make sure I pushed back up the
change.
Maxiters is not supported in the old astropy version.
> On Jun 9, 2020, at 6:12 PM, Tuan Do ***@***.***> wrote:
>
>
> It looks like calib.py was not importing astropy stats. Also astropy
stats does not support the maxiters keyword in the version of astropy (2.0)
that works with pyraf and astroconda?
>
> You can view, comment on, or merge this pull request online at:
>
> #15
>
> Commit Summary
>
> fixed some astropy stats issues
> File Changes
>
> M nirc2/reduce/calib.py (16)
> Patch Links:
>
> https://github.com/jluastro/nirc2/pull/15.patch
> https://github.com/jluastro/nirc2/pull/15.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY56PYJMRLMK7GNTUCYBO3RV3XDPANCNFSM4NZ5FIDQ>
.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'll note that we tested thoroughly last summer only through the clean step (to derive distortion solutions). So I think combo might still have other issues too. We need to confirm that all the DAR keywords are correct (most importantly the angles). |
…r pipeline including aotsxy keywords
Sorry, didn't realize my previous pull request never got merged. This commit is not ready for a pull request |
fits.setval(new_file, 'CAMNAME', value = 'narrow') # from NIRC2 | ||
|
||
return | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am replacing this with a generic flip code that works in either direction and uses the date to figure out which way to flip.
@@ -145,6 +145,9 @@ def clean(files, nite, wave, refSrc, strSrc, badColumns=None, field=None, | |||
radecRef = [float(hdr1['RA']), float(hdr1['DEC'])] | |||
aotsxyRef = nirc2_util.getAotsxy(hdr1) | |||
|
|||
if instrument.name == 'OSIRIS': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move this to the instrument. I think each instrument will need to know how to calculate its own offsets, right?
@@ -433,7 +436,17 @@ def combine(files, wave, outroot, field=None, outSuffix=None, | |||
########## | |||
|
|||
# Load the strehl_source.txt file | |||
strehls, fwhm = loadStrehl(cleanDir, roots) | |||
if (weight is not None) or os.path.exists(os.path.join(cleanDir,'strehl_source.txt')): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The weights=None is a great addition. I think in the case that no file exists, we should probably throw and exception and let the user know.
It looks like calib.py was not importing astropy stats. Also astropy stats does not support the maxiters keyword in the version of astropy (2.0) that works with pyraf and astroconda?