Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator metadata should apply to the assertion, not the outcome. #14

Closed
jmakeig opened this issue Aug 30, 2016 · 1 comment
Closed

Operator metadata should apply to the assertion, not the outcome. #14

jmakeig opened this issue Aug 30, 2016 · 1 comment
Assignees
@jmakeig
Labels
bug ⚑ important
Milestone
1.0

Comments

@jmakeig
Copy link
Owner

jmakeig commented Aug 30, 2016

https://medium.com/javascript-scene/why-i-use-tape-instead-of-mocha-so-should-you-6aa105d8eaf4#.d9z6m6nb2

TAP version 13
# A passing test
ok 1 This test will pass.
# Assertions with tape.
not ok 2 Given two mismatched values, .equal() should produce a nice bug report
  ---
    operator: equal
    expected: 'something to test'
    actual:   'sonething to test'
  ...
1..2
# tests 2
# pass 1
# fail 1
@jmakeig jmakeig added the bug label Aug 30, 2016
@jmakeig jmakeig added this to the 1.0 milestone Aug 30, 2016
@jmakeig jmakeig self-assigned this Aug 30, 2016
@jmakeig
Copy link
Owner Author

jmakeig commented Sep 6, 2016

Should also refactor using a generic internal assert method, like Tape.

jmakeig added a commit that referenced this issue Sep 18, 2016
@jmakeig
Fixes #14: Propagate operator
2ce7f08 
Refactors with centralized assert method, rather than pass/fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmakeig jmakeig

Labels
bug ⚑ important
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@jmakeig