Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMakelists.txt #97

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Added CMakelists.txt #97

merged 1 commit into from
Jun 16, 2023

Conversation

npranav7619
Copy link
Contributor

Associated Issue

Closes Issue #71

Implemented Solution

Added CMakeLists.txt which can be used with cmake to compile and build

running

cmake CMakeLists.txt
make all

will compile and generate the binary

@welcome
Copy link

welcome bot commented Jun 14, 2023

Thanks for opening this pull request for myanimelist-cli!
Please wait shortly for someone to review.
https://media1.tenor.com/images/de54dcf0d5723e5c190b36aed008917f/tenor.gif

@ghost
Copy link

ghost commented Jun 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jmakhack
Copy link
Owner

Thanks for working on this. On quick review, it looks good.

I will test it on my machine later and if it builds properly, I will approve and merge your changes.

Copy link
Owner

@jmakhack jmakhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the build is working with CMake on my machine.

@jmakhack jmakhack merged commit 2875812 into jmakhack:master Jun 16, 2023
@welcome
Copy link

welcome bot commented Jun 16, 2023

Congrats on merging your first pull request to myanimelist-cli!
Please give our project a star if you like what we are building here.
https://media1.tenor.com/images/7eaebbe5e4d63fc9b5f029d0bab363e3/tenor.gif

@jmakhack
Copy link
Owner

@all-contributors please add @npranav7619 for code and maintenance

@allcontributors
Copy link
Contributor

@jmakhack

I've put up a pull request to add @npranav7619! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants