Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 8 position issues #5

Closed
batjo opened this issue Aug 13, 2014 · 18 comments
Closed

iOS 8 position issues #5

batjo opened this issue Aug 13, 2014 · 18 comments

Comments

@batjo
Copy link

batjo commented Aug 13, 2014

Thanks for this amazing popup! I want to put in inside an app that I'm making but with iOS 8 around the corner I was wondering if you are going to fix position problems. Have a look at the screenshot.

Also the fade out animation flickers a bit.

ios simulator screen shot 13 aug 2014 10 49 56

@jmascia
Copy link
Owner

jmascia commented Aug 14, 2014

Hey @bartjochems, glad you like the popup! I'm sorry about the issues on iOS 8. I will look into it shortly. I think I should be able to fix it by this weekend...

@batjo
Copy link
Author

batjo commented Aug 15, 2014

That would be really great! Thanks a lot

@SamStone92
Copy link

Any updates for iOS 8?

@jmascia
Copy link
Owner

jmascia commented Sep 2, 2014

Did a lot of testing and figured out the issues. Just need to clean up my code and then I'll commit.

@SamStone92
Copy link

Amazing, thank you.

Sent from my iPhone

On 2 Sep 2014, at 08:34, Jeff Mascia notifications@github.com wrote:

Did a lot of testing and figured out the issues. Just need to clean up my code and then I'll commit.


Reply to this email directly or view it on GitHub.

@frankcortes
Copy link

What is the current state for this issue? This bug is really annoying for the user experience. We are going to publish an app in the App Store and we would need to fix this before.

@batjo
Copy link
Author

batjo commented Sep 10, 2014

Hi @jmascia I did some more testing and found another problem when the orientation changes. Have a look at the attached screenshots:
ios simulator screen shot 10 sep 2014 14 44 50
ios simulator screen shot 10 sep 2014 14 44 40

Looking forward to a new release!

@iremk
Copy link

iremk commented Sep 21, 2014

any luck on fixing this issue?
looking forward to it.

@ancloid
Copy link

ancloid commented Sep 26, 2014

Quick fix orientation for iPad landscape only:

in KLCPopup.m search for :
self.transform = CGAffineTransformMakeRotation(angle);
self.frame = self.window.bounds;

change with:
if (floor(NSFoundationVersionNumber) <= NSFoundationVersionNumber_iOS_7_1) {
self.transform = CGAffineTransformMakeRotation(angle);
self.frame = self.window.bounds;
}

@ristkari
Copy link

Wonderng whether there will be fix? It would be greatly appreciated :)

@ghost
Copy link

ghost commented Sep 30, 2014

anclefeudor's fix for the iPad orientation issue did the trick for me. Many thanks and very nice control!

@batjo
Copy link
Author

batjo commented Oct 6, 2014

@jmascia any plans on releasing a new version?

@jmascia
Copy link
Owner

jmascia commented Oct 9, 2014

I put out a new version that should fix layout and rotation issues in iOS 8. Let me know if you find any issue, or give it a go yourself ;)

Apologies for the long wait on this. It's been a busy time both at home and work. Thanks for understanding.

@jmascia jmascia closed this as completed Oct 9, 2014
@batjo
Copy link
Author

batjo commented Oct 9, 2014

Thanks a lot!

@petr-fiala
Copy link

great PopUp! definitely going to use it in my projects. There is still problem with orientations on iOS8... fix is super simple, already written in comments above, why won't you push it?

@fedemame
Copy link

@jmascia please merge the @anclefeudor fix, there is still a rotation bug in iOS 8.
Congratulation for the component anyway ;)

@khaledannajar
Copy link

Hi cocoapods always get version 1.0 and the fix is in version 1.1. Have you updated the cocoapods repository? @jmascia

pod error:

[!] Unable to satisfy the following requirements:

- `KLCPopup (~> 1.1)` required by `Podfile`

@HarishSami
Copy link

When We Drag the KCLPopup.h and .m files to our project it cannot be working. Getting TypeNum redefinition Error. I can not write any code in .h and .m files. I am using Xcode 9.4.1. Is there ant Podfile for this KCLPopup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests