Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 Compatibility #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MusikPolice
Copy link

Conditional upgrade of future to v0.18.3 and tabulate to v0.9.0 if and only if python version is > v3.10. This fixes the error "ImportError: cannot import name 'Iterable' from 'collections' in Python" on Python 3.10 and higher.

Tested on Ubuntu 22.04.2 LTS:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy

with python version 3.10.6 and pip version 22.0.2

…ython version is > v3.10. This fixes the error 'ImportError: cannot import name Iterable from collections in Python' on Python 3.10 and higher.
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2023

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage: 90.61%. Remained the same when pulling 6e34643 on MusikPolice:musikpolice/python-3.10 into 76ad823 on jmathai:master.

@jmathai
Copy link
Owner

jmathai commented Mar 23, 2023

Thanks for submitting. Tests are only running on python 3.8 at the moment and supporting python3.10 is a mess atm (see gh-418).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants