Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #11

Merged
merged 2 commits into from
Aug 23, 2020
Merged

Performance #11

merged 2 commits into from
Aug 23, 2020

Conversation

jmboehm
Copy link
Owner

@jmboehm jmboehm commented Aug 7, 2020

Many of the macros are generating code that is not type stable, and is therefore horrendously slow. This affects in particular

  • egen/erep (fixed with first commit)
  • generate/replace <-- should use Tables.namedtupeiterator and a barrier function
  • reshape
    maybe more?

@jmboehm jmboehm self-assigned this Aug 7, 2020
@jmboehm jmboehm marked this pull request as draft August 7, 2020 23:23
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #11 into master will increase coverage by 1.05%.
The diff coverage is 92.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   76.64%   77.69%   +1.05%     
==========================================
  Files          17       18       +1     
  Lines         608      677      +69     
==========================================
+ Hits          466      526      +60     
- Misses        142      151       +9     
Impacted Files Coverage Δ
src/Douglass.jl 100.00% <ø> (ø)
src/commands/duplicates.jl 100.00% <ø> (ø)
src/helper.jl 88.23% <86.20%> (-7.22%) ⬇️
src/commands/erep.jl 93.33% <93.33%> (ø)
src/commands/egen.jl 95.91% <96.87%> (-1.27%) ⬇️
src/commands/drop.jl 100.00% <100.00%> (ø)
src/commands/generate.jl 91.42% <100.00%> (ø)
src/commands/keep.jl 100.00% <100.00%> (ø)
src/commands/replace.jl 91.89% <100.00%> (ø)
src/commands/reshape.jl 65.00% <100.00%> (+0.89%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09cd0bb...b4b5fa8. Read the comment docs.

@jmboehm jmboehm marked this pull request as ready for review August 23, 2020 20:35
@jmboehm
Copy link
Owner Author

jmboehm commented Aug 23, 2020

Merging this sooner rather than later. reshape_long is still painfully slow, which I think is coming from the fact that DataFrames.stack is slow (probably not type stable).

Some bug fixes too.

Also, this is changing the version to 0.0.1, in preparation for registration.

@jmboehm jmboehm merged commit 3bc01e8 into master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant