dump parameter was removed in apispec 0.20

[lafrech]

This line

flask-apispec/flask_apispec/apidoc.py

Line 70 in 2f8429c

dump=False,

should be removed since that parameter was removed in apispec 0.20.0: marshmallow-code/apispec@7009b17.

See the change I made in flask-rest-api: marshmallow-code/flask-smorest@4a239d5.

[rth]

@lafrech Sounds reasonable. Are you sure this is still an issue with the current version on master?

Your fork seems fairly outdated: e.g. flask-apispec minimal requirement for apispec is >=0.4.1 while in your fork it's apispec>=0.20.0. It also has 40 less commits than master...

[lafrech]

Not sure which fork you're talking about. We don't use flask-apispec, we use our own framework (flask-rest-api, the one I link to).

I think flask-apispec is broken if used with apispec 0.20.0. I contributed the change in apispec and it is a breaking change so I thought I'd stop by to tell you.

My suggestion is you do the same as I did in the flask-rest-api commit I pointed to:

• bump apispec requirement to 0.20.0
• remove dump parameter

Just a friendly hint. None of my business, actually.

[rth]

Aww, right, my mistake, got confused by all the flask-* names. PRs to fix it, would be welcome ...

[rth]

though raising the minimum requirement from apispec version >=0.4.1 (released 2015-10-20) to >=0.20.0 (released 2017-03-19) would be more problematic as it could break users code. It might be better to do some conditional code to support both versions. Thanks for opening this issue..

[Donal-Flanagan]

Nice catch @lafrech. I just ran into this bug too.
TypeError: fields2parameters() got an unexpected keyword argument 'dump'

[ffleandro]

I'm experiencing this bug too.
Using flask-apispec from master, and apispec 0.20.0.

[rth]

I'm experiencing this bug too.

It's not a bug, it's a breaking change upstream.. ) Should be fixed with #45 .

[sloria]

Fixed.