Fix imports for browser.py file #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import fixed : - from requests.packages.urllib3.util.retry import Retry to from urllib3 import Retry (And add 'urllib3' to setup.py) - from werkzeug import cached_property to from werkzeug.utils import cached_property All tests passed except for test_reduce_age: AssertionError.
This was referenced Feb 14, 2020
|
Is this project's maintainer still active? This seems to be a relatively simple change that resolves a breaking issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import fixed :
All tests passed except for test_reduce_age: AssertionError.