Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: Socket.io #22

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Closed

[Parser]: Socket.io #22

jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Assignees
@jmcdo29
Labels
enhancement 🐺 A new feature to be implemented Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged socket.io A problem with the socket.io parser
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include Socket.io in the request logging.

Looking for: package under the name @ogma/platform-socket.io that exports a class SocketioInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output of this is still to be determined. Some values may need to be hard-coded
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented socket.io A problem with the socket.io parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
jmcdo29 added a commit that referenced this issue Mar 28, 2020
@jmcdo29
feat(socket.io): implements parser for socket.io
21dfff1 
The SocketioInterceptorParser has two hardcoded values, one for method and one for protocol. It also
only has the concept of pass (200) and fail (500), though there could be a case for checking if the
error is an `HttpException` and if so getting the status from there like is done in the HttpParsers.

fix #22
jmcdo29 added a commit that referenced this issue Mar 28, 2020
@jmcdo29
feat(socket.io): implements parser for socket.io
6da8fdb 
The SocketioInterceptorParser has two hardcoded values, one for method and one for protocol. It also
only has the concept of pass (200) and fail (500), though there could be a case for checking if the
error is an `HttpException` and if so getting the status from there like is done in the HttpParsers.

fix #22
@jmcdo29 jmcdo29 added Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged and removed good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed labels Mar 29, 2020
@jmcdo29 jmcdo29 self-assigned this Apr 17, 2020
@jmcdo29 jmcdo29 closed this as completed Apr 21, 2020
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(socket.io): implements parser for socket.io
c489313 
The SocketioInterceptorParser has two hardcoded values, one for method and one for protocol. It also
only has the concept of pass (200) and fail (500), though there could be a case for checking if the
error is an `HttpException` and if so getting the status from there like is done in the HttpParsers.

fix #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement 🐺 A new feature to be implemented Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged socket.io A problem with the socket.io parser
Projects
None yet
Milestone
@ogma/namespace
Development

No branches or pull requests
1 participant
@jmcdo29