feat: rewrite the parser gathering logic #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36ff6d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 9a3daa2. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
jmcdo29
changed the base branch from
feat/nest-module-5.0.0
to
feat/nestjs-module-5.0.0
Instead of forcing the user to register one of the four paresers and being stuck with only those contexts, users can now add parers to a `providers` array and let the `DiscoveryService` find the parsers and then use the correct one based on the context type. This allows for custom contexts like necord's `discord` context, to have parsers created and used for it without having to change the context or assume a certain type for it. Docs, changesets, and extra tests to come soon related: #1451
jmcdo29
force-pushed
the
feat/context-parser
branch
from
9a3daa2
to
55b862c
Compare
jmcdo29
force-pushed
the
feat/context-parser
branch
from
1290888
to
f00252d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forcing the user to register one of the four paresers and being stuck with only those contexts, users can now add parers to a
providersarray and let theDiscoveryServicefind the parsers and then use the correct one based on the context type. This allows for custom contexts like necord'sdiscordcontext, to have parsers created and used for it without having to change the context or assume a certain type for it.Docs, changesets, and extra tests to come soon
related: #1451