fix: make sonic boom work inside of worker threads #1734
Conversation
🦋 Changeset detectedLatest commit: 5b8dbe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| stream.on('error', filterBrokenPipe); | ||
| // if we are sync: false, we must flush on exit | ||
| if (!opts.sync && isMainThread) { |
There was a problem hiding this comment.
Making a note for myself more than anything:
We don't pass the opts.sync option in first place, and child_process does not have an isMainThread property, so this will always evaluate to !false && false i.e. it will always be false. As such, we can remove a good bit of this file and clean things up a bit
If we're inside a worker thread, the process.stdout.fd is undefined which causes a panic in sonic boom and crashes the application. Defaulting to `1` fixes the issue.
jmcdo29
force-pushed
the
fix/sonic-boom-opts
branch
from
74b9bc3
to
e67b383
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5b8dbe3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
If we're inside a worker thread, the process.stdout.fd is undefined
which causes a panic in sonic boom and crashes the application.
Defaulting to
1fixes the issue.