Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create instrumentation package with minimal tests #1822

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

jmcdo29
Copy link
Owner

@jmcdo29 jmcdo29 commented Jul 23, 2024

The tests need to be re-worked significantly, originally they were written for mocha (what otel's repo uses), but I need to either re-write them for uvu or move everything ovwer to vitest as uvu's development seems to have stagnated

Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: 03a37fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ogma/instrumentation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

gitguardian bot commented Jul 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11599482 Triggered Nx Cloud Token 03a37fe nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Jul 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03a37fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@jmcdo29 jmcdo29 merged commit d02fa21 into main Jul 23, 2024
13 of 14 checks passed
@jmcdo29 jmcdo29 deleted the feat/instrumentation branch July 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant