Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: convert testing-nestjs into monorepo with Lerna #1222

Closed
omermorad opened this issue Feb 13, 2021 · 3 comments · Fixed by #1516
Closed

Suggestion: convert testing-nestjs into monorepo with Lerna #1222

omermorad opened this issue Feb 13, 2021 · 3 comments · Fixed by #1516
Assignees
@jmcdo29
Labels
enhancement New feature or request

Comments

@omermorad
Copy link

omermorad commented Feb 13, 2021 •
edited
Loading

@jmcdo29 I thought about it, what do you think about changing this repo to work with Lerna where every sample will be a package? 😃

Then we can manage a CHANGELOG.md file and use some Semver methodological as well
@omermorad omermorad added the enhancement New feature or request label Feb 13, 2021
@jmcdo29
Copy link
Owner

jmcdo29 commented Feb 13, 2021

The original idea behind the nest monorepo was to give the monorepo method a shot. Overall, I'd prefer a pnpm workspace over lerna (I like pnpm over the other packages managers), but if you want to try your hand at converting it, go for it 😄

@omermorad
Copy link
Author

I see. Actually, I've never used pnpm before.
So do you want to give lerna a shot with the classic npm?

Take into account it's going to be a big change :)
So after converting it we will need to merge it quickly in order to avoid merge hell

@jmcdo29
Copy link
Owner

jmcdo29 commented Feb 13, 2021

pnpm workspaces are incredibly similar to lerna to be honest. I'll work on making the change though. It also supports the workspace: protocol, like yarn does, so they should be closely compatible. I haven't checked in npm supports that yet or not

jmcdo29 added a commit that referenced this issue Dec 31, 2021
@jmcdo29
chore: migrate to nx monorepo
3b26a54 
I'm moving over from a Nest monorepo to an [nx][1] monorepo to allow for
easier development and more robust commands. The ability to use `npm run nx affected:test`
to take care of all of the changed tests at once is incredibly useful. Also, it helps with
running the projects locally via compiling with webpack, and generally has a better DX in
my honest opinion. Plus, it can allow for a useful refactor pattern later, and better exposure
to using Nx.

closes #1222

[1]: https://nx.dev
@jmcdo29 jmcdo29 mentioned this issue Dec 31, 2021
Merged
jmcdo29 added a commit that referenced this issue Dec 31, 2021
@jmcdo29
chore: migrate to nx monorepo
a6cef53 
I'm moving over from a Nest monorepo to an [nx][1] monorepo to allow for
easier development and more robust commands. The ability to use `npm run nx affected:test`
to take care of all of the changed tests at once is incredibly useful. Also, it helps with
running the projects locally via compiling with webpack, and generally has a better DX in
my honest opinion. Plus, it can allow for a useful refactor pattern later, and better exposure
to using Nx.

closes #1222

[1]: https://nx.dev
jmcdo29 added a commit that referenced this issue Jan 1, 2022
@jmcdo29
chore: migrate to nx monorepo
be3976e 
I'm moving over from a Nest monorepo to an [nx][1] monorepo to allow for
easier development and more robust commands. The ability to use `npm run nx affected:test`
to take care of all of the changed tests at once is incredibly useful. Also, it helps with
running the projects locally via compiling with webpack, and generally has a better DX in
my honest opinion. Plus, it can allow for a useful refactor pattern later, and better exposure
to using Nx.

closes #1222

[1]: https://nx.dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate to nx monorepo jmcdo29/testing-nestjs
2 participants
@omermorad @jmcdo29