Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exceptions on filter URL parameters parsing #3247

Closed
knstvk opened this issue May 15, 2024 · 0 comments · Fixed by #3248
Closed

Suppress exceptions on filter URL parameters parsing #3247

knstvk opened this issue May 15, 2024 · 0 comments · Fixed by #3248
Assignees
Milestone

Comments

@knstvk
Copy link
Contributor

knstvk commented May 15, 2024

URL parameters are unreliable, they can be easily changed in such a way that the app will not be able to parse them correctly, for example when copy-pasting the URL.

Another case when a parameter cannot be parsed is when the filter contains a condition for a non-JPA entity and DataManager cannot load this instance by id (found when implementing #709).

Now FilterUrlQueryParametersSupport throws exceptions when it cannot parse the parameters or load entity instance, and these exceptions are shown to the user in the Unexpected Exception dialog.

I would suggest to suppress such exceptions and just print a message to the server log. The corresponding filter condition will just be cleared.

@knstvk knstvk added in: flowui triage Issue is waiting for triage labels May 15, 2024
@knstvk knstvk linked a pull request May 15, 2024 that will close this issue
@gorbunkov gorbunkov added size: S and removed triage Issue is waiting for triage labels May 17, 2024
@gorbunkov gorbunkov added this to the 2.3.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants