Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid localeDisplayName message keys for several translation add-ons #3407

Closed
Gasloff opened this issue Jun 20, 2024 · 1 comment
Closed

Invalid localeDisplayName message keys for several translation add-ons #3407

Gasloff opened this issue Jun 20, 2024 · 1 comment
Assignees
@gorbunkov
Labels
in: translations size: S type: bug Something isn't working
Milestone
2.3.0

Comments

@Gasloff
Copy link
Contributor

Gasloff commented Jun 20, 2024 •
edited
Loading

Environment

Jmix version: 2.3.0.RC1

Bug Description

Italian, Arabic and Romanian translation add-ons have localeDisplayName.en message key with local language name defined in core/messages_xx.properties file, instead of localeDisplayName.it, localeDisplayName.ar and localeDisplayName.ro

So this languages have names in english in Jmix UI:
Screenshot 2024-06-20 at 18 23 03
@Gasloff Gasloff added type: bug Something isn't working in: translations triage Issue is waiting for triage labels Jun 20, 2024
@gorbunkov gorbunkov added size: S and removed triage Issue is waiting for triage labels Jun 21, 2024
@gorbunkov gorbunkov self-assigned this Jun 21, 2024
gorbunkov added a commit that referenced this issue Jun 21, 2024
@gorbunkov
Invalid localeDisplayName message keys for several translation add-ons …
feea4b5 
…#3407
gorbunkov added a commit that referenced this issue Jun 21, 2024
@gorbunkov
Invalid localeDisplayName message keys for several translation add-ons …
fd2c772 
…#3407

(cherry picked from commit feea4b5)
@gorbunkov
Copy link
Contributor

For Arabic translation, there is no messages_ar.properties for the core module. So there is no localeDisplayName property that I can change.

@gorbunkov gorbunkov added this to the 2.3.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorbunkov gorbunkov

Labels
in: translations size: S type: bug Something isn't working
Projects
Release 2.3
Status: Done
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@gorbunkov @Gasloff