-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using shim + noParse leads to undefined variable error #89
Comments
Hey @rpflorence! Cool to see you're using grunt-browserify! As of right now, browserify-shim requires the libraries being shimmed to be parsed. I'm going to leave this ticket open, though, as a reminder to update the documentation to specify this limitation. |
And if you're looking for faster build times, I'd just suggest moving the shimmed libraries into a separate vendor subtask, so that you don't need to recompile on every client code change. |
@jmreidy I was able to make this situation work in mimosa-browserify by creating a transform that inserts |
@JonET Interesting! Do you know if this approach would still work for libraries that need to be shimmed with outside dependencies? |
Seems to be resolving things okay. (conifg) |
Awesome! I'll merge this in. Thanks @JonET! |
That screenshot isn't right (global.$ is defined before the require('jquery') call). But Handlebars wasn't. So yep, it works. |
For anyone that is experiencing this problem, could you try the |
Published in v1.2.7 |
thanks for this code snippet! was trying to find nice way to handle the ember suite |
As soon as I add the noParse option I get this error in the browser:
Uncaught ReferenceError: global is not defined
Here's my config:
The text was updated successfully, but these errors were encountered: