Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album covers are cropped on very slim/tall screens #324

Closed
Maxr1998 opened this issue Sep 7, 2022 · 6 comments
Closed

Album covers are cropped on very slim/tall screens #324

Maxr1998 opened this issue Sep 7, 2022 · 6 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@Maxr1998
Copy link
Contributor

Maxr1998 commented Sep 7, 2022

On screens with a high aspect ratio that are tall but slim (like the cover screen on the Samsung Z Fold 4), covers are cropped on the sides.

Instead of cropping them, they should be fit inside the screen dimensions, with some additional padding, e.g. at the top to visually center the cover.

Screenshot_20220907_142329.png

@Chaphasilor
Copy link
Collaborator

This will eventually be fixed by #220, not sure if @jmshrv wants to add a temporary fix for this...

@jmshrv
Copy link
Owner

jmshrv commented Sep 7, 2022

I'll look in to this :)

@Chaphasilor
Copy link
Collaborator

@Maxr1998 can you try it on the latest redesign branch? I made some changes to hopefully better support different screen sizes with the redesign :)

@Maxr1998
Copy link
Contributor Author

Maxr1998 commented Feb 8, 2024

Seems pretty good! During my quick test I noticed the album screen is a little odd now, but that's another issue.

Screenshots

Screenshot_20240208_234442.png
Screenshot_20240208_234436.png

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented Feb 8, 2024

Awesome, thanks. Yeah that screen will be redesigned anyway so I won't dive into cosmetic fixes for the time being ^^

@Maxr1998
Copy link
Contributor Author

Maxr1998 commented Feb 8, 2024

Understood. A popup menu or something might be preferable anyway so that it's not so crowded.

Anyways, sorry for taking so long to reply and thanks for fixing the album art issue. The redesign branch already looks really nice, great work!

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

3 participants