Test winter-2020 branch #2
Conversation
jelaniwoods
commented
Feb 21, 2020
•
jelaniwoods
commented
| @@ -0,0 +1,40 @@ | |||
| <h1>Sign up</h1> | |||
|
|
|||
| <form action="/post_task_doer" method="post"> | |||
There was a problem hiding this comment.
This needs to change to either a get to /insert_task_doer or the route needs to change to post.
| </h5> | ||
|
|
||
| <div> | ||
| <form action="/patch_task_doer" method="post"> |
There was a problem hiding this comment.
This needs to be updated to /modify_task_doer
| <% end %> | ||
| <% end %> | ||
| <div> | ||
| <form action="/patch_task_doer" method="post"> |
There was a problem hiding this comment.
Again /modify_task_doer
| <%= time_ago_in_words(task.created_at) %> ago | ||
| </td> | ||
| <td> | ||
| <%= time_ago_in_words(task.updated_at) %> ago |
There was a problem hiding this comment.
Do we keep the time_ago_in_words? We haven't really talked about it at all.
There was a problem hiding this comment.
@jelaniwoods Hm, I was planning to talk about it in class. However I've been wanting to leave certain easy improvements out of the draft:resource generator in order to make it more obvious who is actually putting in effort and who is not, so I may remove this.
| get("/task_doer_sign_up", { :controller => "task_doers", :action => "new_registration_form" }) | ||
|
|
||
| # Create record | ||
| get("/insert_task_doer", { :controller => "task_doers", :action => "create" }) |
There was a problem hiding this comment.
The should most likely be a post request I think. If an account has a text or file column they will need it. Also to not have the password in the form.
