Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, calling
check_all_int
[1] with floating-point numbers < 1, e.g.results in
Reason is mainly that
int(0.5)=0
and theni % int(i)
is undefined.This happens for example when solving 0-1-knapsack with profits, weights or capacity < 1 (method="mt1r") [2]. Note that we don't have to check if the values are integers if the method is already "mt1r", so changing
check_all_int
is just a quick-fix and not a code refactoring.Hope it helps, thank you!
[1] https://github.com/jmyrberg/mknapsack/blob/master/mknapsack/_utils.py#L21
[2] https://github.com/jmyrberg/mknapsack/blob/master/mknapsack/_single.py#L95