Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify regexp support #83

Closed
wavebeem opened this issue Jul 3, 2016 · 1 comment
Closed

Clarify regexp support #83

wavebeem opened this issue Jul 3, 2016 · 1 comment

Comments

@wavebeem
Copy link
Collaborator

wavebeem commented Jul 3, 2016

Some flags for regexps cannot be reasonably supported within Parsimmon, so let's make it an error to use them!

Only i, u, and m make sense to support https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp.

Thanks to everyone in #81 for the discussion that brought up this issue!

I think it might make sense to just put this check in the assertRegexp function.

@wavebeem
Copy link
Collaborator Author

wavebeem commented Jul 4, 2016

Also, the documentation should explicitly state that all regexps are wrapped in ^(?: ◊ ), and we should clarify which regexp flags are supported.

@wavebeem wavebeem mentioned this issue Jul 7, 2016
wavebeem pushed a commit that referenced this issue Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant