Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop requirement for regexps to be anchored #9

Closed
michaelficarra opened this issue Jan 9, 2014 · 1 comment
Closed

drop requirement for regexps to be anchored #9

michaelficarra opened this issue Jan 9, 2014 · 1 comment

Comments

@michaelficarra
Copy link
Contributor

There's no need for that. Just use RegExp.prototype.exec and make sure the index property of the result is 0. I'll send over a PR soon.
@jneen
Copy link
Owner

jneen commented Jan 9, 2014

That would be great, if you know a way to do it such that the implementation doesn't have to search the entire input stream.

@michaelficarra michaelficarra mentioned this issue Jan 9, 2014
Merged
laughinghan added a commit that referenced this issue Jan 19, 2014
@laughinghan
Merge pull request #10 from michaelficarra/GH-9
92be8da 
fixes #9: no longer require regexps to be anchored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelficarra @jneen