Fix error formatting bug #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfzebra
commented
Jun 25, 2018
| @@ -481,15 +480,23 @@ function formatGot(input, error) { | |||
| column = columnByteIndex * 3; | |||
|
|
|||
| // Account for an extra space. | |||
| if (columnByteIndex > 4) { | |||
| if (columnByteIndex >= 4) { | |||
There was a problem hiding this comment.
This is where the error occurred.
There was a problem hiding this comment.
aha! i've been there before 😄
wavebeem
approved these changes
Jun 25, 2018
| @@ -481,15 +480,23 @@ function formatGot(input, error) { | |||
| column = columnByteIndex * 3; | |||
|
|
|||
| // Account for an extra space. | |||
| if (columnByteIndex > 4) { | |||
| if (columnByteIndex >= 4) { | |||
There was a problem hiding this comment.
aha! i've been there before 😄
| var answer = Parsimmon.formatError(input, parser.parse(input)); | ||
|
|
||
| assert.deepEqual(answer, expectation); | ||
| }); |
There was a problem hiding this comment.
thank you for the thorough tests!!
|
Thanks! Released as v1.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a bug discovered by @wavebeem in issue #239
Introduces tests and minor refactoring.