Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XML-ish example #308

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Add XML-ish example #308

merged 1 commit into from
Sep 19, 2020

Conversation

anko
Copy link
Contributor

@anko anko commented Sep 18, 2020

Add an example parser of a subset of XML, as @wavebeem suggested. I tried to follow the style of other examples.

It seems the changelog hasn't mentioned addition of previous usage examples either, so I didn't touch it.

  • I have run npm run lint:fix to ensure Prettier and ESLint have passed
  • Coveralls bot has replied that the tests pass with 100% code coverage (npm test)
  • I have updated CHANGELOG.md

Add a basic parser of a subset of XML, as suggested;
jneen#307 (comment)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 063cbb6 on anko:xmlish-example into 62f9b15 on jneen:master.

@wavebeem wavebeem merged commit efe046d into jneen:master Sep 19, 2020
@wavebeem
Copy link
Collaborator

Good call; examples don't need to go in the changelog :) Thanks for submitting this PR

@anko anko deleted the xmlish-example branch September 19, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants